Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Wrong formula in Matrix3.fromHeadingPitchRoll() #5195

Closed
emackey opened this issue Apr 10, 2017 · 2 comments · Fixed by #5202
Closed

Wrong formula in Matrix3.fromHeadingPitchRoll() #5195

emackey opened this issue Apr 10, 2017 · 2 comments · Fixed by #5202

Comments

@emackey
Copy link
Contributor

emackey commented Apr 10, 2017

Reported by @zimengyang in this comment

I double checked Cesium's implementation in Matrix3.fromHeadingPitchRoll(), there is a bug here:
Cesium/Core/Matrix3.js, line 321, formula here is incorrect,

The correct formula is:
var m12 = -sinPhi * cosPsi + cosPhi * sinTheta * sinPsi;

Instead of
var m12 = -sinTheta * cosPhi + cosPhi * sinTheta * sinPsi;

@pjcozzi
Copy link
Contributor

pjcozzi commented Apr 12, 2017

@rahwang could you open a pull request with the fix?

@rahwang
Copy link
Contributor

rahwang commented Apr 12, 2017

@pjcozzi yep! On it!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants