Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Camera moveForward/moveBackward broken in 2D view #5884

Closed
thw0rted opened this issue Oct 5, 2017 · 5 comments · Fixed by #6133
Closed

Camera moveForward/moveBackward broken in 2D view #5884

thw0rted opened this issue Oct 5, 2017 · 5 comments · Fixed by #6133
Labels
category - sandcastle cleanup good first issue An opportunity for first time contributors

Comments

@thw0rted
Copy link
Contributor

thw0rted commented Oct 5, 2017

Go to the Sandcastle demo for Camera control, switch to 2D, and try the W/S keys. The camera moves toward or away from the map in 3D and Columbus, but does not move in 2D.

@thw0rted
Copy link
Contributor Author

thw0rted commented Oct 5, 2017

I just noticed that ScreenSpaceCameraController uses Camera.zoomIn instead of moveForward. This works fine.

@ggetz
Copy link
Contributor

ggetz commented Oct 5, 2017

@thw0rted OK to close?

@thw0rted
Copy link
Contributor Author

thw0rted commented Oct 6, 2017

Well, at least somebody should update the demo to pick the function based on the mode, but also I don't think that moveForward should have no effect at all in 2D mode.

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 10, 2017

@thw0rted if you have the time, it would be great for you to open a small pull request to update the Sandcastle example, thanks!

@thw0rted
Copy link
Contributor Author

It would be simple enough to update the example, but I do think that moveForward should be fixed to move toward the map in 2D mode (which would make the Sandcastle update unnecessary).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
category - sandcastle cleanup good first issue An opportunity for first time contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants