Skip to content

Exception when calling TimeInterval.fromIso8601 #6164

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
tamarmot opened this issue Jan 26, 2018 · 3 comments
Closed

Exception when calling TimeInterval.fromIso8601 #6164

tamarmot opened this issue Jan 26, 2018 · 3 comments
Labels
category - doc cleanup good first issue An opportunity for first time contributors

Comments

@tamarmot
Copy link
Contributor

Sample date string: "2020-08-29T00:00:00+00:00"
I can call:
JulianDate.fromIso8601 with success
When I try to call
Cesium.TimeInterval.fromIso8601({iso8601:"2020-08-29T00:00:00+00:00"});
I get an exception: Invalid ISO 8601 date.

@shunter
Copy link
Contributor

shunter commented Jan 26, 2018

Time intervals contain two ISO dates separated by slash:

https://en.wikipedia.org/wiki/ISO_8601#Time_intervals

Arguably the error message could be better.

@hpinkos hpinkos added cleanup category - doc good first issue An opportunity for first time contributors labels Jan 26, 2018
@hpinkos
Copy link
Contributor

hpinkos commented Jan 26, 2018

Let's add a link to https://en.wikipedia.org/wiki/ISO_8601#Time_intervals in the doc for TimeInterval.fromIso8601, and throw a DeveloperError if options.iso8601 does not contain a '/'.

@tamarmot
Copy link
Contributor Author

tamarmot commented Jan 26, 2018 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
category - doc cleanup good first issue An opportunity for first time contributors
Projects
None yet
Development

No branches or pull requests

3 participants