Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Flag new/updated Sandcastle examples #6384

Closed
pjcozzi opened this issue Mar 28, 2018 · 6 comments
Closed

Flag new/updated Sandcastle examples #6384

pjcozzi opened this issue Mar 28, 2018 · 6 comments
Labels
category - sandcastle good first issue An opportunity for first time contributors

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 28, 2018

Right now, users have to look at CHANGES.md or I guess the file timestamps to see what new examples are in a release.

It would be cool if there was a Sandcastle tab (or other type of sorting / highlighting) where it is easy to discover the new / significantly updated examples.

Could maybe even automate it as part of the build.

Folks were asking for the same thing for three.js at GTC

@pjcozzi pjcozzi added good first issue An opportunity for first time contributors category - sandcastle labels Mar 28, 2018
@mramato
Copy link
Contributor

mramato commented Mar 28, 2018

For automation, this should be easy by having createGalleryList look at new files since the previous release git tag.

@emackey
Copy link
Contributor

emackey commented Mar 28, 2018

This is a great idea. Probably shouldn't use file timestamps for this though. Git log can identify what's changed lately in a particular branch, or we could manually flag some each release.

@emackey
Copy link
Contributor

emackey commented Mar 28, 2018

For example, if a developer has been working on a branch that has changed demos, and then swaps back to master to build a release, the datestamps on those files will get touched to "now" as the demos are reset back to their old master state. They would be incorrectly flagged as new.

Likewise, on a fresh clone, everything is new.

@mramato
Copy link
Contributor

mramato commented Mar 28, 2018

Just do: git diff --name-only --diff-filter=A 1.43 HEAD Apps/Sandcastle/gallery/*.html and you're done.

@emackey
Copy link
Contributor

emackey commented Mar 28, 2018

@mramato That's perfect.

@mramato
Copy link
Contributor

mramato commented Mar 28, 2018

PR incoming.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
category - sandcastle good first issue An opportunity for first time contributors
Projects
None yet
Development

No branches or pull requests

3 participants