Made czm_imagerySplitPosition use absolute coordinates. Fixes #5106. #5151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everything looks good to me! Thanks, @jasonbeverage ! Tried your branch and can confirm the fix. Should be good to merge @pjcozzi . |
|
Very nice, thanks @jasonbeverage and @rahwang! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
czm_imagerySplitPosition now computes absolute pixel coordinates from the relative public property during UniformState.update to fix issues with the date line. The public imagerySplitPosition is still in relative coordinates. I think this is a better fix than #5124 so users don't have to worry about the canvas being resized and it also avoids having to deprecate the imagerySplitPosition public property.