Add setter for KmlDataSource.name #5660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpinkos
reviewed
Jul 20, 2017
CHANGES.md
Outdated
| @@ -16,6 +16,7 @@ Change Log | |||
| * Added ability to show tile urls in the 3D Tiles Inspector. [#5592](https://github.com/AnalyticalGraphicsInc/cesium/pull/5592) | |||
| * Added behavior to `Cesium3DTilesInspector` that selects the first tileset hovered over if no tilest is specified. [#5139](https://github.com/AnalyticalGraphicsInc/cesium/issues/5139) | |||
| * Added ability to provide a `width` and `height` to `scene.pick`. [#5602](https://github.com/AnalyticalGraphicsInc/cesium/pull/5602) | |||
| * Added setter for `KkmlDataSource.name` to specify a name for the datasource. | |||
hpinkos
reviewed
Jul 20, 2017
Source/DataSources/KmlDataSource.js
Outdated
| * This will be automatically be set to the KML document name on load. | ||
| * @memberof KmlDataSource.prototype | ||
| * @type {String} | ||
| */ | ||
| name : { | ||
| get : function() { | ||
| return this._name; | ||
| }, | ||
| set : function(value) { | ||
| if(this._name !== value) { |
There was a problem hiding this comment.
Add a space after if: if(this -> if (this
|
@hpinkos Can you trigger a rebuild? This should be ready |
|
Thanks @burn123! I just pushed a change to remove an extra line of whitespace, then I'll merge this as soon as CI passes. |
|
@hpinkos I think there is something wrong with the Travis builds, because I keep getting timeout errors |
|
No problem. We pushed a few changes last week that fixed CI in master, but your branch might not be up to date. I ran the test locally and everything is great. Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5656.
This allows the ability to set the name of a
KmlDataSource.