Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't send key with every Bing tile request. #6250

Merged
merged 2 commits into from
Feb 22, 2018

Conversation

shunter
Copy link
Contributor

@shunter shunter commented Feb 21, 2018

Key is only needed on the initial metadata request.

Regression from #6035.

Key is only needed on the initial metadata request.
@cesium-concierge
Copy link

Signed CLA is on file.

@shunter, thanks for the pull request! Maintainers, we have a signed CLA from @shunter, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor

hpinkos commented Feb 21, 2018

Thanks @shunter! Is this worth mentioning in CHANGES.md?

@shunter
Copy link
Contributor Author

shunter commented Feb 22, 2018

I updated CHANGES. It's a minor thing that didn't cause any correctness problems but I imagine would be a minor performance hit by defeating Bing's server-side CDN caching.

@hpinkos hpinkos merged commit 4e4f0d9 into master Feb 22, 2018
@hpinkos hpinkos deleted the dont-send-key-with-bing-tiles branch February 22, 2018 15:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants