Tileset content.url to content.uri #6744

ggetz · 2018-06-27T21:05:26Z

Part of #6697

To reflect updates to the 3D Tiles spec, deprecated support for 3D Tiles content.url in favor of content.uri.

Also added a test to make sure tilesets using data uri's for their content load and render.

TODO:

Once the PR is merged, add a note to Remove 3D Tiles deprecation warnings #5363.
Update sample tilesets

cesium-concierge · 2018-06-27T21:05:27Z

@ggetz, thanks for the pull request! Maintainers, we have a signed CLA from @ggetz, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

hpinkos · 2018-06-27T21:07:49Z

CHANGES.md

@@ -8,6 +8,8 @@ Change Log
 * Dropped support for directory URLs when loading tilesets to match the updated [3D Tiles spec](https://github.com/AnalyticalGraphicsInc/3d-tiles/issues/272). [#6502](https://github.com/AnalyticalGraphicsInc/cesium/issues/6502)
 * KML and GeoJSON now use `PolylineGraphics` instead of `CorridorGraphics` for polylines on terrain. [#6706](https://github.com/AnalyticalGraphicsInc/cesium/pull/6706)

+* Support for 3D Tiles `content.url` is deprecated to reflect updates to the [3D Tiles spec](https://github.com/AnalyticalGraphicsInc/3d-tiles/pull/301) and will be removed in Cesium 1.50. Use `content.uri instead`. [#6744](https://github.com/AnalyticalGraphicsInc/cesium/pull/6744)


whitespace above this

lilleyse

Looks good @ggetz!

lilleyse · 2018-07-03T13:53:32Z

Specs/Data/Cesium3DTiles/Tilesets/TilesetWithContentUri/tileset.json

@@ -0,0 +1,41 @@
+{
+  "asset": {
+    "version": "0.0"


Set to version 1.0.

lilleyse · 2018-07-03T13:56:39Z

CHANGES.md

@@ -8,6 +8,9 @@ Change Log
 * Dropped support for directory URLs when loading tilesets to match the updated [3D Tiles spec](https://github.com/AnalyticalGraphicsInc/3d-tiles/issues/272). [#6502](https://github.com/AnalyticalGraphicsInc/cesium/issues/6502)
 * KML and GeoJSON now use `PolylineGraphics` instead of `CorridorGraphics` for polylines on terrain. [#6706](https://github.com/AnalyticalGraphicsInc/cesium/pull/6706)

+##### Deprecated :hourglass_flowing_sand:
+* Support for 3D Tiles `content.url` tileset JSON property is deprecated to reflect updates to the [3D Tiles spec](https://github.com/AnalyticalGraphicsInc/3d-tiles/pull/301) and will be removed in Cesium 1.50. Use `content.uri instead`. [#6744](https://github.com/AnalyticalGraphicsInc/cesium/pull/6744)
+


Given the discussion in #5363, remove the note about being removed in Cesium 1.50 and mention that it is deprecated but will be kept around for backwards compatibility purposes.

lilleyse · 2018-07-03T13:56:59Z

CHANGES.md

@@ -8,6 +8,9 @@ Change Log
 * Dropped support for directory URLs when loading tilesets to match the updated [3D Tiles spec](https://github.com/AnalyticalGraphicsInc/3d-tiles/issues/272). [#6502](https://github.com/AnalyticalGraphicsInc/cesium/issues/6502)
 * KML and GeoJSON now use `PolylineGraphics` instead of `CorridorGraphics` for polylines on terrain. [#6706](https://github.com/AnalyticalGraphicsInc/cesium/pull/6706)

+##### Deprecated :hourglass_flowing_sand:
+* Support for 3D Tiles `content.url` tileset JSON property is deprecated to reflect updates to the [3D Tiles spec](https://github.com/AnalyticalGraphicsInc/3d-tiles/pull/301) and will be removed in Cesium 1.50. Use `content.uri instead`. [#6744](https://github.com/AnalyticalGraphicsInc/cesium/pull/6744)
+


"Use content.uri instead" -> "Use content.uri instead"

lilleyse · 2018-07-03T14:38:41Z

CHANGES.md

@@ -8,6 +8,9 @@ Change Log
 * Dropped support for directory URLs when loading tilesets to match the updated [3D Tiles spec](https://github.com/AnalyticalGraphicsInc/3d-tiles/issues/272). [#6502](https://github.com/AnalyticalGraphicsInc/cesium/issues/6502)
 * KML and GeoJSON now use `PolylineGraphics` instead of `CorridorGraphics` for polylines on terrain. [#6706](https://github.com/AnalyticalGraphicsInc/cesium/pull/6706)

+##### Deprecated :hourglass_flowing_sand:
+* Support for 3D Tiles `content.url` tileset JSON property is deprecated to reflect updates to the [3D Tiles spec](https://github.com/AnalyticalGraphicsInc/3d-tiles/pull/301) and will be removed in Cesium 1.50. Use `content.uri instead`. [#6744](https://github.com/AnalyticalGraphicsInc/cesium/pull/6744)
+


I was late for 1.47, so just move up to the 1.48 section.

lilleyse · 2018-07-03T14:40:20Z

Specs/Scene/Cesium3DTilesetSpec.js

@@ -117,6 +117,8 @@ defineSuite([
    var tilesetReplacementWithViewerRequestVolumeUrl = 'Data/Cesium3DTiles/Tilesets/TilesetReplacementWithViewerRequestVolume/tileset.json';

    var tilesetWithExternalResourcesUrl = 'Data/Cesium3DTiles/Tilesets/TilesetWithExternalResources/tileset.json';
+    var tilesetUrlWithContentUri = 'Data/Cesium3DTiles/Tilesets/TilesetWithContentUri/tileset.json';


Will there be a pull request into https://github.com/AnalyticalGraphicsInc/3d-tiles-tools for this new tileset?

Created PR CesiumGS/3d-tiles-validator#149 for running changes. I would think review that last after the Cesium changes.

ggetz · 2018-07-05T15:23:47Z

Thanks @lilleyse , updated!

lilleyse · 2018-07-05T15:28:34Z

Thanks!

Tileset content.url to content.uri

a6baaf3

ggetz requested a review from lilleyse June 27, 2018 21:05

Update CHANGES.md

164d1e9

hpinkos reviewed Jun 27, 2018

View reviewed changes

Fix CHANGES.md

4034a3d

lilleyse mentioned this pull request Jul 3, 2018

Remove 3D Tiles deprecation warnings #5363

Closed

lilleyse reviewed Jul 3, 2018

View reviewed changes

ggetz added 3 commits July 5, 2018 11:21

Merge branch 'master' into tileset-url-to-uri

8a9a7d5

Update CHANGES.md and specified correct tileset version

263b193

Update CHANGES.md

a4e07e3

lilleyse merged commit b387130 into master Jul 5, 2018

lilleyse deleted the tileset-url-to-uri branch July 5, 2018 15:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tileset content.url to content.uri #6744

Tileset content.url to content.uri #6744

ggetz commented Jun 27, 2018 •

edited

Loading

cesium-concierge commented Jun 27, 2018

hpinkos Jun 27, 2018

lilleyse left a comment

lilleyse Jul 3, 2018

lilleyse Jul 3, 2018

lilleyse Jul 3, 2018

lilleyse Jul 3, 2018

lilleyse Jul 3, 2018

ggetz Jul 5, 2018

ggetz commented Jul 5, 2018

lilleyse commented Jul 5, 2018

Tileset content.url to content.uri #6744

Tileset content.url to content.uri #6744

Conversation

ggetz commented Jun 27, 2018 • edited Loading

cesium-concierge commented Jun 27, 2018

hpinkos Jun 27, 2018

Choose a reason for hiding this comment

lilleyse left a comment

Choose a reason for hiding this comment

lilleyse Jul 3, 2018

Choose a reason for hiding this comment

lilleyse Jul 3, 2018

Choose a reason for hiding this comment

lilleyse Jul 3, 2018

Choose a reason for hiding this comment

lilleyse Jul 3, 2018

Choose a reason for hiding this comment

lilleyse Jul 3, 2018

Choose a reason for hiding this comment

ggetz Jul 5, 2018

Choose a reason for hiding this comment

ggetz commented Jul 5, 2018

lilleyse commented Jul 5, 2018

ggetz commented Jun 27, 2018 •

edited

Loading