Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix geocoder: true #6833

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Fix geocoder: true #6833

merged 2 commits into from
Jul 25, 2018

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jul 24, 2018

Fixes #6826

@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@mramato
Copy link
Contributor

mramato commented Jul 24, 2018

Do all of the other widgets already handle this case?

@hpinkos
Copy link
Contributor Author

hpinkos commented Jul 24, 2018

@mramato yes, geocoder was the only one we were overloading this option for

@mramato
Copy link
Contributor

mramato commented Jul 25, 2018

Thanks @hpinkos!

@mramato mramato merged commit bb22e1c into master Jul 25, 2018
@mramato mramato deleted the fix-geocoder branch July 25, 2018 03:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants