Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix OIT analytical shadows crash #6883

Merged
merged 3 commits into from
Aug 8, 2018
Merged

Fix OIT analytical shadows crash #6883

merged 3 commits into from
Aug 8, 2018

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Aug 5, 2018

Fixes #6873

@lb999255 could you check if this fixes the crash you saw?

To do:

  • Not really sure how to write a test for this yet. fromLightSource=false isn't tested in general.
  • CHANGES.md

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@lilleyse
Copy link
Contributor Author

lilleyse commented Aug 5, 2018

Updated. Added test for fromLightSource=false that fails in master and passes here.

@bagnell can you review?

@bagnell
Copy link
Contributor

bagnell commented Aug 7, 2018

The code changes look good to me. I can confirm that the test fails in master and works in this branch. I'll merge once @lb999255 confirms this fixes the issue.

@flyingdq
Copy link

flyingdq commented Aug 8, 2018

I got the branch and tested on my local project. It's running fine now. Thanks for your help! @lilleyse @bagnell

@bagnell bagnell merged commit 2e9cf8b into master Aug 8, 2018
@bagnell bagnell deleted the oit-shadow-fix branch August 8, 2018 19:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

only one shadow map enabled with fromLightSource=false caused error
4 participants