Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix ground polyline with dynamic color #6927

Merged
merged 5 commits into from
Aug 20, 2018
Merged

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Aug 16, 2018

Fixes #6925

This is the same thing we do for other static geometry types, we must have just missed putting it in for ground polyline

@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@bagnell
Copy link
Contributor

bagnell commented Aug 17, 2018

Code looks good. Can you add a test?

@hpinkos
Copy link
Contributor Author

hpinkos commented Aug 17, 2018

Thanks @bagnell, this is ready

@bagnell
Copy link
Contributor

bagnell commented Aug 17, 2018

The test you added passes in master.

@hpinkos hpinkos force-pushed the fix-ground-polyline-color branch from 9fd6edc to 3172896 Compare August 20, 2018 13:27
@hpinkos
Copy link
Contributor Author

hpinkos commented Aug 20, 2018

@bagnell fixed

@bagnell
Copy link
Contributor

bagnell commented Aug 20, 2018

Thanks 👍

@bagnell bagnell merged commit b62e7b6 into master Aug 20, 2018
@bagnell bagnell deleted the fix-ground-polyline-color branch August 20, 2018 19:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants