Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

clampToHeightMostDetailed fix #7690

Merged
merged 5 commits into from
Apr 4, 2019
Merged

clampToHeightMostDetailed fix #7690

merged 5 commits into from
Apr 4, 2019

Conversation

lilleyse
Copy link
Contributor

Fixes #7621

Resolves the promise of clampToHeightMostDetailed and sampleHeightMostDetailed during the postRender event to ensure that entities are never created mid-frame, which is anywhere between viewer._onTick and viewer._postRender.

The order of events in a single render loop is basically:

  1. viewer._onTick
  2. updateAsyncRayPicks (in scene.render) (this is renamed to updateMostDetailedRayPicks in @loshjawrence's branch)
    2.a. Synchronous pick calls immediately when the async ray is ready
  3. viewer._postRender (first subscriber to scene.postRender)
  4. The rest of scene.postRender including these new events.

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse lilleyse force-pushed the most-detailed-fix branch from 16a3f39 to 5fc443d Compare March 30, 2019 03:22
Copy link
Contributor

@loshjawrence loshjawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works in the staging branch too.

@lilleyse
Copy link
Contributor Author

lilleyse commented Apr 4, 2019

Thanks @loshjawrence, I'll merge it in.

@lilleyse lilleyse merged commit 502f34a into master Apr 4, 2019
@lilleyse lilleyse deleted the most-detailed-fix branch April 4, 2019 19:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants