Use DiscardEmptyTileImagePolicy for all Bing styles. #7810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @shunter!
Reviewers, don't forget to make sure that:
|
shunter
force-pushed
the
bingMapsDiscardPolicy
branch
from
cbc2429 to
c3e60fa
Compare
This removes the need to inspect pixel values to detect the placeholder "missing tile" image. Also change `DiscardEmptyTileImagePolicy.EMPTY_IMAGE` to be a real (blank) image. This way we always satisfy the documented API of `requestImage`. Fixes #1353.
shunter
force-pushed
the
bingMapsDiscardPolicy
branch
from
c3e60fa to
9966a08
Compare
|
Works as promised. Thanks @shunter! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need to inspect pixel values to detect the placeholder "missing tile" image.
Also change
DiscardEmptyTileImagePolicy.EMPTY_IMAGEto be a real (blank) image.This way we always satisfy the documented API of
requestImage.Fixes #1353.