Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Gamma correction fix for polylines #7924

Merged
merged 3 commits into from
Jun 10, 2019
Merged

Gamma correction fix for polylines #7924

merged 3 commits into from
Jun 10, 2019

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Jun 8, 2019

Some polyline shaders were missing gamma correction.

Fixes #7920

@lilleyse lilleyse requested a review from hpinkos June 8, 2019 14:52
@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

Copy link
Contributor

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GLSL changes look fine. @hpinkos I think you just need to test if these things look the right color (or at least, consistent colors) after this, like you did on the linked issue.

@hpinkos
Copy link
Contributor

hpinkos commented Jun 10, 2019

Thanks @emackey!

Yeah, looks good @lilleyse =)

@hpinkos hpinkos merged commit 0c0307a into master Jun 10, 2019
@hpinkos hpinkos deleted the gamma-correct-fix branch June 10, 2019 20:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HDR colors polylines with PolylineColorAppearance and PolylineMaterialAppearance differently
4 participants