Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

invalid_type_inside_abi exception #2079

Open
heifner opened this issue Jan 12, 2024 · 1 comment
Open

invalid_type_inside_abi exception #2079

heifner opened this issue Jan 12, 2024 · 1 comment
Labels
bug Something isn't working 👍 lgtm
Milestone

Comments

@heifner
Copy link
Member

heifner commented Jan 12, 2024

The invalid_type_inside_abi is defined as

      FC_DECLARE_DERIVED_EXCEPTION( invalid_type_inside_abi,           abi_exception,
                                    3015004, "The type defined in the ABI is invalid" ) // Not to be confused with abi_type_exception

Note the comment Not to be confused with abi_type_exception. Looks like it has been confused. It should be used only when validating the ABI.
I believe these uses in abi_serializer::_variant_to_binary are incorrect. The exception there should be abi_type_exception.

EOS_THROW( invalid_type_inside_abi, "Unknown type ${type}", ("type",ctx.maybe_shorten(type)) );

EOS_ASSERT( st.base == type_name(), invalid_type_inside_abi,

EOS_ASSERT( s_itr != structs.end(), invalid_type_inside_abi, "Unknown type ${type}", ("type",ctx.maybe_shorten(type)) );

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jan 12, 2024
@bhazzard bhazzard added bug Something isn't working 👍 lgtm and removed triage labels Jan 16, 2024
@bhazzard bhazzard added this to the Leap v5.0.1 milestone Jan 16, 2024
@bhazzard
Copy link

This can comfortably slide into 6.0.0 instead of 5.x if necessary... fit into 5.0.1 opportunistically.

@ericpassmore ericpassmore modified the milestones: Leap v5.0.1, Leap v6.0.1 Mar 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working 👍 lgtm
Projects
Archived in project
Development

No branches or pull requests

4 participants