Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Eliminate methods for Endpoints #19

Closed
aidan-casey opened this issue Sep 3, 2020 · 0 comments
Closed

Eliminate methods for Endpoints #19

aidan-casey opened this issue Sep 3, 2020 · 0 comments
Milestone

Comments

@aidan-casey
Copy link
Member

I would love to change the syntax slightly for endpoints on the client wrapper. I just need to figure out the right (performant) way to do this.

For example:

// This
$client->tickets()->findById(1);

// Becomes this
$client->tickets->findById(1);

I think it looks cleaner. The question just becomes whether it would have a performance impact to instantiate all 160 service classes on construct or if there is a better way to come at this with __get().

Also, it'd be a breaking change, so version 1.0.0 if we do this.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant