Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

too large websocket message cause offline #2082

Closed
Handgrip opened this issue Jan 9, 2023 · 5 comments
Closed

too large websocket message cause offline #2082

Handgrip opened this issue Jan 9, 2023 · 5 comments

Comments

@Handgrip
Copy link

Handgrip commented Jan 9, 2023

When I manually edit the json document and save it, when the json document is too large, it will lead to offline(websocket no response).
image

image

image

@Handgrip
Copy link
Author

Handgrip commented Jan 9, 2023

image
seems related to #2024, I'm using https://studio.apicur.io/, was it updated to the lasted version?

@blackjack4494
Copy link

Having the exact same issue here also on the official web version.
When I try to add an example response it will immediately lose connection and won't reconnect no matter what I do. Even deleting the input won't let me reconnect.
This already happens with smallish examples of around 1mb.

@EricWittmann
Copy link
Member

I thought this was fixed on https://studio.apicur.io/ in this change: https://github.com/Apicurio/apicurio-studio/blob/master/platforms/quarkus/ws/src/main/resources/application.properties#L25

I believe the latest version with that change is deployed. But apparently not. I will investigate.

Note: another improvement that we should consider is to send a JSON Diff as the payload for a source code change, rather than the entire source. Not sure if I'll ever reasonably have time to implement that though.

@EricWittmann
Copy link
Member

It seems that @romilin fixed this in #2124 - I apparently typed the property incorrectly in application.properties. :(

I'll get a release done and deployed asap.

@EricWittmann
Copy link
Member

This should be finally fixed and released/pushed to studio.apicur.io. I'm going to close this but please re-open if it is still not working!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants