Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improvement - Collaboration #351

Closed
gigaga opened this issue Jul 19, 2018 · 4 comments
Closed

Improvement - Collaboration #351

gigaga opened this issue Jul 19, 2018 · 4 comments

Comments

@gigaga
Copy link

gigaga commented Jul 19, 2018

Currently, to enable collaborate work, each API owner has to launch invitation for each others members (individually.
I will be great if we can share our API for everyone (authenticated users) too.

@EricWittmann
Copy link
Member

Thanks for the PR on this. However, I'm a little concerned with maintenance of the SQL layer long-term. This change requires that I maintain two separate SQL statements for a number of DB calls. I'm wondering what you'd think if rather than having a global setting that effectively disables the ACL, we instead add a feature whereby an API owner can mark an API as "public". So the "share with everyone" feature would need to be turned on for each API individually, but would allow both "public" and "private" APIs to exist simultaneously. It would also mean that I can maintain a single set of SQL statements, which should be better long-term I think.

Thoughts?

@gigaga
Copy link
Author

gigaga commented Jul 25, 2018

I added a global setting to avoid to change database model too :D
In fact, in my team (30 persons), add write right for each people individually is not possible. Allow to declare some API as public will be great. Private mode will be never used...

@EricWittmann
Copy link
Member

OK understood, thanks!

@EricWittmann
Copy link
Member

This has been resolved by: #355

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants