Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unit Test: HTTP Client #741

Closed
EricWittmann opened this issue Apr 19, 2019 · 0 comments
Closed

Unit Test: HTTP Client #741

EricWittmann opened this issue Apr 19, 2019 · 0 comments
Assignees
Labels

Comments

@EricWittmann
Copy link
Member

We have had numerous problems with Java HTTP clients not properly working with some URLs, specifically from GitLab. As a result, I'm always hesitant to upgrade the version of the HTTP client we're using. To increase confidence, we should create a simple unit test that does the following:

  1. start up an echo HTTP server
  2. make problematic HTTP calls using the apicurio http client
  3. assert that the echo response is what it should be

An example of a problematic gitlab endpoint is:

https://docs.gitlab.com/ee/api/repository_files.html#get-file-from-repository

The file_path component of the URL must be an encoded file path. But many of the HTTP clients end up mangling the URL and un-encoding the path, which is then not recognized by GitLab.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant