Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

PyAqueduct to return timezone aware time object #9

Closed
samiralavi opened this issue Apr 17, 2024 · 1 comment · Fixed by #15 or AqueductHub/aqueductcore#57
Closed

PyAqueduct to return timezone aware time object #9

samiralavi opened this issue Apr 17, 2024 · 1 comment · Fixed by #15 or AqueductHub/aqueductcore#57
Assignees
@samiralavi
Labels
enhancement New feature or request

Comments

@samiralavi
Copy link
Contributor

samiralavi commented Apr 17, 2024 •
edited
Loading

The current datetime object returned by the Experiment object doesn't have the timezone information. This should be fixed once the server returns UTC timezone. Our current objects are “Naive” - we should make them “Aware” by adding timezone info (just specifying that the current timezone of the objects is UTC is perfect)
@samiralavi samiralavi self-assigned this Apr 17, 2024
@samiralavi
Copy link
Contributor Author

samiralavi commented Apr 18, 2024 •
edited
Loading

This issue is blocked by this issue

@safeamiiir safeamiiir moved this from Todo to In Progress in Aqueduct Project Apr 19, 2024
@samiralavi samiralavi linked a pull request Apr 19, 2024 that will close this issue
fix(refactor): Make AqueductClient a private member of the API and Experiment classes. #15
Merged
@samiralavi samiralavi moved this from In Progress to In Review in Aqueduct Project Apr 23, 2024
@samiralavi samiralavi linked a pull request Apr 23, 2024 that will close this issue
fix(timezone): Add timezone awareness to time operations based on UTC. AqueductHub/aqueductcore#57
Merged
@github-project-automation github-project-automation bot moved this from In Review to Done in Aqueduct Project Apr 23, 2024
@samiralavi samiralavi added the enhancement New feature or request label May 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@samiralavi samiralavi

Labels
enhancement New feature or request
Projects
No open projects
Aqueduct Project
Archived in project
Milestone
No milestone
1 participant
@samiralavi