Refactor start_server function #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teohhanhui
commented
Jun 13, 2024
| }); | ||
| } | ||
|
|
||
| fn set_child_processes(&self, child_processes: usize) { |
There was a problem hiding this comment.
It is of course unnecessary to take child_processes as a parameter. But it reads better? 😆
teohhanhui
force-pushed
the
refactor/start-server
branch
from
dcbcd52 to
7fec4f8
Compare
Signed-off-by: Teoh Han Hui <teohhanhui@gmail.com>
teohhanhui
force-pushed
the
refactor/start-server
branch
from
7fec4f8 to
debec39
Compare
|
/ping @slp If we could have this merged first, I'd love to do more refactoring on other parts (especially the problems identified in the previous PR). |
|
Looks much nicer now, thanks! |
slp
approved these changes
Jun 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.