Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feature-request: use new --video-crop for cropping operations #21

Closed
dyphire opened this issue Sep 1, 2023 · 1 comment
Closed

feature-request: use new --video-crop for cropping operations #21

dyphire opened this issue Sep 1, 2023 · 1 comment

Comments

@dyphire
Copy link

dyphire commented Sep 1, 2023

Ref: mpv-player/mpv#12246
This will optimize performance and fix #19

Note that this does not bring hwdec support.

@Ashyni
Copy link
Owner

Ashyni commented Sep 3, 2023

Hello,

I started to do some test with video-crop, every crop change looks smoother than lavfi-crop, i will implement it properly, your PR miss multiple stuff, thanks for your contribution anyway.

Has for #19, this issue is related to cropdetect filter chain and not crop, so it doesn't change anything.
And it's partially fixed with read_ahead_mode=0 (disable) in 7246723 and actually fully fixed with read_ahead_mode=1/2 (enable) by patch/ffmpeg/0001-avfilter-add-vf_dummysync.patch which need to be discussed with ffmpeg dev.

For now, the script remains limited to soft decoding or hwdec=*-copy.

@Ashyni Ashyni closed this as completed in 0e60cb4 Sep 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants