11.15 breaks codebase

[tomvo]

Describe the bug
setDefaultLocale(): Return value must be of type Astrotomic\Translatable\Contracts\Translatable, App\Route returned

This happened when upgrading minor version to .15 and to be honest I don't think return type changes should be part of minor version jumps.

background
I'm setting the default locale of a specific model in an observer based on a DB value so that an object is always returned in the language the user forces it in.

[Gummibeer]

So you return your model but your model does implement the interface?

[Oleksandr-Moik]

@Gummibeer, Yes, I can confirm. In my own experience, my colleagues and I don't always implement the interface in a model, we just a trait and that's enough for us.

Therefore, I suggest to use only phpdoc, at least for now.

Type added in b46b3cc18140a54af3ecba7938f58569dcae86d6

[Gummibeer]

Thanks for confirmation. I will release a fix that will revert the interface type changes.

[Gummibeer]

With e6b3c13 & 18d1328 I fix the type changes introduced in #406

[Gummibeer]

https://github.com/Astrotomic/laravel-translatable/releases/tag/v11.15.1

[tomvo]

hey @Gummibeer sorry for my late reply and missing background info but I'm glad @Oleksandr-Moik added some more details as that was indeed the scenario.