Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use external tools for formatting and style #509

Open
spco opened this issue Nov 7, 2023 · 1 comment
Open

Use external tools for formatting and style #509

spco opened this issue Nov 7, 2023 · 1 comment

Comments

@spco
Copy link
Collaborator

spco commented Nov 7, 2023

We currently roll our own Fortran formatters: tools/fix_style.py and tools/fix_indent.py. Since the main development work on AtChem2, things in the Fortran world have really come on - I suggest we make use of https://github.com/pseewald/fprettify instead. It'll reduce our own estate we need to maintain, and be more robust and better tested.

In a similar vein, we should run https://pypi.org/project/black/ on our Python files - it's very opinionated but that's the point, removing our own preferences.

If you agree (with either), I'd be happy to make a PR. I'd recommend merging #497 first, as it'll undoubtedly change stuff all over the place.

@rs028
Copy link
Collaborator

rs028 commented Nov 10, 2023

This sounds like a good idea, both for Python and Fortran.

@rs028 rs028 added this to Roadmap Nov 27, 2023
@rs028 rs028 moved this to Minor Improvements in Roadmap Nov 27, 2023
@rs028 rs028 moved this from Minor Improvements to Wishlist in Roadmap Nov 27, 2023
@rs028 rs028 added this to the version 1.6 milestone Dec 19, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: Wishlist
Development

No branches or pull requests

2 participants