Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

react-hooks/exhaustive-deps fix button #1355

Open
lambert-velir opened this issue Jun 4, 2020 · 2 comments
Open

react-hooks/exhaustive-deps fix button #1355

lambert-velir opened this issue Jun 4, 2020 · 2 comments

Comments

@lambert-velir
Copy link

Issue Type

Bug/Feature Request

Issue Description

It seems that facebook disabled autofix for the react-hooks/exhaustive-deps rule. When I see this linter error, I see the error message, but I do not see a "fix" button, like I do for other linter errors:

Screen Shot 2020-06-04 at 4 27 59 PM

Other rules do have a "fix" button:
Screen Shot 2020-06-04 at 4 29 09 PM

Is this something that needs to be added to linter-eslint? The facebook issue mentions the ESLint Suggestions API, so maybe this packages needs to be updated to use that?

@UziTech
Copy link
Member

UziTech commented Mar 14, 2021

The rule needs to be fixable in order to see the fix button

@UziTech UziTech closed this as completed Mar 14, 2021
@lambert-velir
Copy link
Author

Hi @UziTech, this is a fixable rule in VS Code and it used to work in Atom. As I mentioned above, I think it's because the ESLint Suggestions API has changed. Can we update this package to support the react-hooks/exhaustive-deps fix button?

@UziTech UziTech reopened this Mar 15, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants