Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Typescript types not correct when using in ESM project #276

Open
amarcuse opened this issue Oct 4, 2024 · 1 comment
Open

Typescript types not correct when using in ESM project #276

amarcuse opened this issue Oct 4, 2024 · 1 comment

Comments

@amarcuse
Copy link

amarcuse commented Oct 4, 2024

Something is off in the Typescript types: they work with commonjs, but it wouldn't compile when I upgrade my project to ESM.

I figured out a workaround, but it is ugly:

import HaikunatorImpl from 'haikunator';
const Haikunator = HaikunatorImpl as unknown as typeof HaikunatorImpl.default;
@Atrox
Copy link
Owner

Atrox commented Nov 23, 2024

Do you have any project that can reproduce this? My projects are all full TS + ESM nowadays and I don't have any type issues.

import Haikunator from "haikunator";

const haikunator = new Haikunator();
const test = haikunator.haikunate()

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants