Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add StrictModeError to MongooseError #8148

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Conversation

ouyuran
Copy link
Contributor

@ouyuran ouyuran commented Sep 10, 2019

Summary

StrictModeError is one of possible Mongoose errors, it should be added to MongooseError

Examples

const StrictModeError = require('mongoose').Error

@ouyuran
Copy link
Contributor Author

ouyuran commented Sep 10, 2019

Hi @vkarpov15
How can I re-run the test cases of CI? I pass lint test locally while it was shown as failed in CI.

root@yuran-HVM-domU:/Shared/Automattic/mongoose# npm run lint

mongoose@5.7.0 lint /Shared/Automattic/mongoose
eslint .

root@yuran-HVM-domU:/Shared/Automattic/mongoose# node -v
v10.16.3

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. CI failure looks like a test flake and a linter issue, shouldn't block merging.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants