Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Any Plans to Support Complex Inputs for First-Kind Bessel Function in Puruspe? #28

Open
elgar328 opened this issue Dec 8, 2024 · 2 comments

Comments

@elgar328
Copy link

elgar328 commented Dec 8, 2024

Hello,

I needed the first-kind Bessel function, so I tried using the scilib library. However, I found that the function scilib::math::bessel::j_nu(nu: f64, z: Complex64) -> Complex64 lacked sufficient precision, and the function scilib::math::bessel::j_n(n: i32, x: f64) -> f64 produced completely inaccurate, diverging results.

Switching to puruspe::bessel::Jn resolved the issue, and I’m satisfied with its higher precision compared to scilib.

That said, I’m still using scilib’s j_nu function for complex inputs, but I’d like to fully transition to puruspe if possible. Do you have any plans to support a complex input version of the first-kind Bessel function in puruspe?

Thank you for providing such an excellent library!

@ethanbarry
Copy link
Contributor

I can't speak for @Axect but I was planning to submit PRs for a few complex functions over the winter break. I think we proposed adding num-complex as an optional dependency, behind a feature flag.

@Axect
Copy link
Owner

Axect commented Dec 9, 2024

Hello @elgar328

Thank you for your feedback! I'm really glad to hear that Puruspe's Bessel function is working well for your needs.

Regarding complex number support - yes, we've noticed increasing demand for this functionality. As @ethanbarry mentioned, we plan to implement this by introducing num-complex as an optional dependency behind a feature flag. While the exact timeline isn't set yet, it would be great to coordinate this with @ethanbarry's planned PRs during the winter break for a comprehensive update.

Looking forward to bringing these improvements to Puruspe!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants