feat: intial private kernel #549

dbanks12 · 2023-05-11T23:45:04Z

Description

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Resolves #503

Checklist:

I have reviewed my diff in github, line by line.
Every change is related to the PR description.
I have linked this pull request to the issue(s) that it resolves.
There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
The branch has been merged or rebased against the head of its merge target.
I'm happy for the PR to be merged at the reviewer's next convenience.

… initial private kernel and moving logic between it and the inner kernel

update_end_values leftover

private_kernel_sim function to the inner/init split

kernel circuit

* refactor(sol): use Hash.sha256ToField library where required * fmt :) * feat: expose bytes32 hash directly * fmt: https://i.pinimg.com/originals/81/23/a1/8123a132c007eab782d6ca9bed517eb3.jpg --------- Co-authored-by: Maddiaa0 <addaboy@gmail.com>

* fix: Add checks for arg-type * fix: support arg of 'number' type * fix: correct wrapped fr in acir sim * no need to force encode in some e2e tests! --------- Co-authored-by: Maddiaa0 <addaboy@gmail.com> Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>

* fix: contentHash -> content * fix: update content in nr * fix: update incorrect message hash naming --------- Co-authored-by: Maddiaa0 <addaboy@gmail.com>

native_private_kernel_init.XPP

native_private_kernel_circuit_inner

dbanks12

Looks good to me. I can't approve since I'm an author otherwise I would. Left a few comments but most of them are minor and could be put off to another PR.

circuits/cpp/src/aztec3/circuits/abis/c_bind.test.cpp

circuits/cpp/src/aztec3/circuits/kernel/private/.test.cpp

circuits/cpp/src/aztec3/circuits/kernel/private/common.cpp

circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_init.cpp

circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_init.hpp

circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_init.cpp

circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_inner.cpp

circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_inner.hpp

circuits/cpp/src/aztec3/constants.hpp

circuits/cpp/src/aztec3/circuits/hash.hpp

circuits/cpp/src/aztec3/circuits/kernel/private/c_bind.cpp

circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_init.cpp

yarn-project/circuits.js/src/abis/__snapshots__/abis.test.ts.snap

yarn-project/circuits.js/src/structs/kernel/__snapshots__/index.test.ts.snap

suyash67

Looks good to me after all the comments/suggestions are resolved.

dbanks12 added 2 commits May 11, 2023 23:41

prelim / very-broken commit where Jean and I started implementing the…

55e6016

… initial private kernel and moving logic between it and the inner kernel

merge in master

c3d954b

dbanks12 mentioned this pull request May 12, 2023

Create an 'Initial' Private Kernel Circuit #506

Closed

jeanmon and others added 27 commits May 12, 2023 12:21

wip - fix some compilation issues, remove unused imports, remove

ac8f8f0

update_end_values leftover

wip - some minor changes and comments after pairing with David

ea7816d

Merge branch 'master' into db-jm/initial-private-kernel

6f01a62

wip: additional compilation fixes

080d814

Merge branch 'master' into db-jm/initial-private-kernel

0fe88a6

Refactor helper functions in private kernel tests

952095e

wip - Fix linking issue and comment out some tests

1a4cfb6

wip - repair native and circuit tests

75d5b17

wip - include using double quotes and remove unused code

f294a0a

wip - fixing circuit_create_proof_cbinds test and adapting

6c73b8a

private_kernel_sim function to the inner/init split

wip - fix clang tidy issue

64678ea

Merge branch 'master' into db-jm/initial-private-kernel

3575556

wip - post master merger fixes and remove test on new nullifiers

9f8ebe2

wip - fix clang tidy issue

a5b378f

Merge branch 'master' into db-jm/intial-private-kernel

f4e5e1e

wip - fix clang tidy issue

9a6c83c

wip - fix typescript tests and data structure split

7c07ed3

wip - format typescript

0b5dc0e

wip - replace CONSTRUCTOR_ARGS by FUNCTION_ARGS

7df1400

Merge branch 'master' into db-jm/intial-private-kernel

bd1b7ad

wip - add nullifier and l1-l2-message tree roots in initial private

f0ae663

kernel circuit

Merge branch 'master' into db-jm/intial-private-kernel

db30ebd

wip - post merge fix

9bbef1c

Migrate common.hpp functions into non-templated ones

e71af78

fix: naming consistency in messaging (messageHash -> message) (#641)

3ecd3bc

* fix: contentHash -> content * fix: update content in nr * fix: update incorrect message hash naming --------- Co-authored-by: Maddiaa0 <addaboy@gmail.com>

jeanmon added 3 commits May 23, 2023 14:51

Merge branch 'master' into db-jm/intial-private-kernel

bbd8517

Renaming file native_private_kernel_initial.XPP into

c416a33

native_private_kernel_init.XPP

Rename native_private_kernel_circuit into

c8df3b4

native_private_kernel_circuit_inner

jeanmon self-assigned this May 23, 2023

jeanmon added the C-protocol-circuits Component: Protocol circuits (kernel & rollup) label May 23, 2023

jeanmon added 2 commits May 23, 2023 17:10

Simplify if/else clause on deployment contract boolean in contract logic

7f8c144

Merge branch 'master' into db-jm/intial-private-kernel

f7832d5

jeanmon requested a review from suyash67 May 23, 2023 17:25

jeanmon marked this pull request as ready for review May 23, 2023 17:39

dbanks12 commented May 23, 2023

View reviewed changes