Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Add equality and serialization to poly_triple #172

Merged
merged 5 commits into from
Mar 1, 2023
Merged

feat: Add equality and serialization to poly_triple #172

merged 5 commits into from
Mar 1, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Feb 21, 2023

Description

Noir needs to be able to serialize and deserialize the poly_triple struct. It also needs to be able to check equality of these.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@phated phated requested a review from adr1anh February 24, 2023 14:53
adr1anh
adr1anh approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@adr1anh adr1anh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codygunton codygunton requested a review from ledwards2225 March 1, 2023 14:07
@ledwards2225 ledwards2225 force-pushed the phated/noir-needs-3 branch from 8237885 to 295a8cb Compare March 1, 2023 14:56
@ledwards2225 ledwards2225 merged commit 142b041 into master Mar 1, 2023
@ledwards2225 ledwards2225 deleted the phated/noir-needs-3 branch March 1, 2023 15:20
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@phated @kevaundray
feat: Add equality and serialization to poly_triple (AztecProtocol/ba…
2cef9c4 
…rretenberg#172)

* NOIR NEEDS: Equality method and serialisation are needed for serialising a struct which contains a vector of poly_triple

* Light formatting

* remove added newline

* change to default

* diff nit

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@phated @kevaundray
feat: Add equality and serialization to poly_triple (AztecProtocol/ba…
b95a811 
…rretenberg#172)

* NOIR NEEDS: Equality method and serialisation are needed for serialising a struct which contains a vector of poly_triple

* Light formatting

* remove added newline

* change to default

* diff nit

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@adr1anh adr1anh adr1anh approved these changes

@codygunton codygunton Awaiting requested review from codygunton

@kevaundray kevaundray Awaiting requested review from kevaundray

@dbanks12 dbanks12 Awaiting requested review from dbanks12

@ledwards2225 ledwards2225 Awaiting requested review from ledwards2225

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phated @adr1anh @kevaundray @ledwards2225