Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(dsl)!: add hash index to pedersen constraint #436

Merged
merged 3 commits into from
May 30, 2023
Merged

feat(dsl)!: add hash index to pedersen constraint #436

merged 3 commits into from
May 30, 2023

Conversation

sirasistant
Copy link
Contributor

@sirasistant sirasistant commented May 11, 2023 •
edited
Loading

Description

Adds the hash_index value to the PedersenConstraint used by noir (previously it was always using the default, zero)
Also adds a new cbind to be able to call plookup commit with hash index.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@sirasistant sirasistant force-pushed the arv/noir_hash_index branch from d9a57b9 to 7673912 Compare May 11, 2023 12:06
@sirasistant sirasistant requested review from phated and suyash67 May 11, 2023 15:07
@sirasistant sirasistant marked this pull request as ready for review May 11, 2023 15:07
@sirasistant sirasistant requested a review from kevaundray May 11, 2023 15:32
@sirasistant
Copy link
Contributor Author

I was going to change the noir ref to use my pedersen with domain separator branch but another barretenberg breaking change has landed already #417 which complicates more having a noir branch that works with both breaking changes.
Anyway here is the noir CI run that runs noir tests with this BB branch and the updated aztec_backend and acvm https://github.com/noir-lang/noir/actions/runs/4978028027/jobs/8909135154

@sirasistant sirasistant requested review from phated and vezenovm May 15, 2023 09:12
@sirasistant sirasistant merged commit e0b8804 into master May 30, 2023
@sirasistant sirasistant deleted the arv/noir_hash_index branch May 30, 2023 15:45
sirasistant added a commit that referenced this pull request May 31, 2023
@sirasistant
feat(dsl)!: add hash index to pedersen constraint (#436)
0f07c50 
* feat(noir): add hash index to pedersen constraint

* feat: added pedesen with hash_index in header
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@sirasistant
feat(dsl)!: add hash index to pedersen constraint (AztecProtocol/barr…
be693d2 
…etenberg#436)

* feat(noir): add hash index to pedersen constraint

* feat: added pedesen with hash_index in header
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@sirasistant
feat(dsl)!: add hash index to pedersen constraint (AztecProtocol/barr…
16cf170 
…etenberg#436)

* feat(noir): add hash index to pedersen constraint

* feat: added pedesen with hash_index in header
This was referenced Jul 25, 2023
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

@suyash67 suyash67 Awaiting requested review from suyash67

@phated phated Awaiting requested review from phated

@vezenovm vezenovm Awaiting requested review from vezenovm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirasistant @phated @kevaundray