Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature Request]: Publish new module version only if bicep/json templates are changed #2896

Open
eriqua opened this issue Mar 10, 2023 · 1 comment
Labels
[cat] publishing category: publishing enhancement New feature or request [prio] high importance of the issue: high priority

Comments

@eriqua
Copy link
Contributor

eriqua commented Mar 10, 2023

Description

Update publishing logic to only publish a new version if module templates (bicep/json) are changed. Currently diff is evaluating if any file in the module folder is changed, including tests and readme files, which should not be the case.

This issue must be prioritized as also blocking issue #1648

An additional challenge to this topic is to consider nested and cross referenced modules changes, since those are part of the resulting compiled json template actually published to both bicep registry and template specs.

Suggestion is therefore to consider changes to the resulting compiled json template.

@eriqua eriqua added enhancement New feature or request [cat] publishing category: publishing labels Mar 10, 2023
@github-project-automation github-project-automation bot moved this to Needs triage in Backlog Mar 10, 2023
@eriqua eriqua changed the title [Feature Request]: publish new module version only if bicep/json templates are changed [Feature Request]: Publish new module version only if bicep/json templates are changed Mar 10, 2023
@rahalan
Copy link
Contributor

rahalan commented Mar 14, 2023

Need to compare the json -> exclude metadata first

@rahalan rahalan added the [prio] high importance of the issue: high priority label Mar 14, 2023
@AlexanderSehr AlexanderSehr moved this from Needs triage to To do in Backlog Mar 23, 2023
@AlexanderSehr AlexanderSehr added this to the Azure Verfified Modules (AVM) - CI Issues milestone May 19, 2024
@AlexanderSehr AlexanderSehr removed this from the Azure Verfified Modules (AVM) - CI Issues milestone Jul 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
[cat] publishing category: publishing enhancement New feature or request [prio] high importance of the issue: high priority
Projects
Status: To do
Development

No branches or pull requests

3 participants