Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

virtualNetworkGateways module ExpressRoute sku validation #354

Closed
torivara opened this issue Nov 3, 2021 · 1 comment
Closed

virtualNetworkGateways module ExpressRoute sku validation #354

torivara opened this issue Nov 3, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@torivara
Copy link
Contributor

torivara commented Nov 3, 2021

Description

It seems the input parameter for virtualNetworkGateways module is not tailored for accepting all ExpressRoute gateway sku names. When I am authoring a main Bicep file referencing the virtualNetworkGateways module, I want to send a sku as a parameter.

Error message when authoring this in VSCode:

The property "virtualNetworkGatewaySku" expected a value of type "'Basic' | 'ErGw1AZ' | 'ErGw2AZ' | 'ErGw3AZ' | 'VpnGw1' | 'VpnGw1AZ' | 'VpnGw2' | 'VpnGw2AZ' | 'VpnGw3' | 'VpnGw3AZ'" but the provided value is of type "'ErGw1AZ' | 'ErGw2AZ' | 'ErGw3AZ' | 'HighPerformance' | 'Standard' | 'UltraPerformance'".bicep(BCP036)

Steps to reproduce

  1. Create a main bicep file referencing virtualNetworkGateways module.
  2. Create a parameter input 'gatewaySku' to this main bicep file with validation as noted above.
  3. Use the parameter 'gatewaySku' for configuring virtualNetworkGatewaySku in params for the module.

Screenshots

image

image

Suggested solution

Update validation for module virtualNetworkGatewaySku with these skus:

@description('Required. The Sku of the Gateway.')
@allowed([
  'Basic'
  'VpnGw1'
  'VpnGw2'
  'VpnGw3'
  'VpnGw1AZ'
  'VpnGw2AZ'
  'VpnGw3AZ'
  'Standard'
  'HighPerformance'
  'UltraPerformance'
  'ErGw1AZ'
  'ErGw2AZ'
  'ErGw3AZ'
])
param virtualNetworkGatewaySku string

This solution is deployed locally, and seems to work.

@torivara torivara added the bug Something isn't working label Nov 3, 2021
@torivara
Copy link
Contributor Author

torivara commented Nov 3, 2021

Nevermind this. It was fixed 1 hour ago in #350. Keep up the good work!

@torivara torivara closed this as completed Nov 3, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant