Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversion Script's handling of special cases #834

Closed
AlexanderSehr opened this issue Dec 21, 2021 · 1 comment · Fixed by #1033
Closed

Conversion Script's handling of special cases #834

AlexanderSehr opened this issue Dec 21, 2021 · 1 comment · Fixed by #1033
Labels
bug Something isn't working

Comments

@AlexanderSehr
Copy link
Contributor

The conversion script is unable to deal with the Microsof.Authorization namespace pipelines as they are not referenceing the main deploy.bicep file, but sub_deploy.bicep files and the like.

In the current version of the logic, these references are simply not updated. In a soon to be merged version, they are at least updated to .json. However, this won't solve the problem just yet, as templates like sub_deploy.bicep don't exist in the module's root, but its .bicep folder. As this folder is not just not converted to JSON, but actually deleted, we have to find a different solution.

The easiest might be to reference deploy.json for this namespace post conversion instead. However, as this may still cause problems (e.g. due to a lack of permissions), this must be documented.

Still better as no solution, I guess.

@AlexanderSehr AlexanderSehr added the bug Something isn't working label Dec 21, 2021
@AlexanderSehr AlexanderSehr changed the title Bug Report Conversion Script's handling of special cases Dec 28, 2021
@AlexanderSehr AlexanderSehr added this to the v 0.4 milestone Jan 6, 2022
@rahalan rahalan modified the milestones: v 0.4, v 0.5 Feb 21, 2022
@AlexanderSehr AlexanderSehr linked a pull request Mar 2, 2022 that will close this issue
4 tasks
@AlexanderSehr
Copy link
Contributor Author

Resolved by the rework of the authorization namespace. #1033

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants