Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

The AzureDevOps Platform Pipeline to set the readme is flawed #960

Closed
AlexanderSehr opened this issue Feb 2, 2022 · 0 comments · Fixed by #1067
Closed

The AzureDevOps Platform Pipeline to set the readme is flawed #960

AlexanderSehr opened this issue Feb 2, 2022 · 0 comments · Fixed by #1067
Assignees
Labels
bug Something isn't working

Comments

@AlexanderSehr
Copy link
Contributor

The pipeline (ResourceModules/.azuredevops/platformPipelines/platform.updateReadMe.yml) has 3 issues that must be fixed

  1. The pool reference should be

          ${{ if ne(variables.vmImage, '') }}:
            vmImage: ${{ variables.vmImage }}
          ${{ if ne(variables.poolName, '') }}:
            name: ${{ variables.poolName }}
  2. The input object used in the pipeline did not work at a customer

         $functionInput = @{
              ModulesPath    = Join-Path '$(System.DefaultWorkingDirectory)' 'arm'
              FilePath       = Join-Path '$(System.DefaultWorkingDirectory)' 'arm/README.md'
              Organization   = ('$(Build.Repository.Name)').split('/')[0] # HERE: returned the repo name
              RepositoryName = ('$(Build.Repository.Name)').split('/')[1] # HERE: returned empty
              ColumnsInOrder = @('Name', 'ProviderNamespace','ResourceType')
            }
  1. The pipeline uses the script Set-GitHubReadMeModuleTable @functionInput -Verbose which is not Azure DevOps ready. The script should be updated to take GitHub vs AzureDevOps as an input parameter, should be renamed and also updated accordingly (e.g. the generated module links are all GitHub links)
@AlexanderSehr AlexanderSehr added the bug Something isn't working label Feb 2, 2022
@Msanzdelrio Msanzdelrio self-assigned this Feb 23, 2022
@Msanzdelrio Msanzdelrio linked a pull request Mar 2, 2022 that will close this issue
10 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants