From 0858271637204d8f9a87e07180330db48274bfd9 Mon Sep 17 00:00:00 2001
From: Erika Gressi <erikag@microsoft.com>
Date: Thu, 13 Oct 2022 14:39:16 +0200
Subject: [PATCH 1/2] principalType

---
 .../netAppAccounts/.test/nfs41/deploy.test.bicep              | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/modules/Microsoft.NetApp/netAppAccounts/.test/nfs41/deploy.test.bicep b/modules/Microsoft.NetApp/netAppAccounts/.test/nfs41/deploy.test.bicep
index 2dfbba8ce2..8e6237bb0b 100644
--- a/modules/Microsoft.NetApp/netAppAccounts/.test/nfs41/deploy.test.bicep
+++ b/modules/Microsoft.NetApp/netAppAccounts/.test/nfs41/deploy.test.bicep
@@ -51,6 +51,7 @@ module testDeployment '../../deploy.bicep' = {
               resourceGroupResources.outputs.managedIdentityPrincipalId
             ]
             roleDefinitionIdOrName: 'Reader'
+            principalType: 'ServicePrincipal'
           }
         ]
         serviceLevel: 'Premium'
@@ -77,6 +78,7 @@ module testDeployment '../../deploy.bicep' = {
                   resourceGroupResources.outputs.managedIdentityPrincipalId
                 ]
                 roleDefinitionIdOrName: 'Reader'
+                principalType: 'ServicePrincipal'
               }
             ]
             subnetResourceId: resourceGroupResources.outputs.subnetResourceId
@@ -110,6 +112,7 @@ module testDeployment '../../deploy.bicep' = {
               resourceGroupResources.outputs.managedIdentityPrincipalId
             ]
             roleDefinitionIdOrName: 'Reader'
+            principalType: 'ServicePrincipal'
           }
         ]
         serviceLevel: 'Premium'
@@ -123,6 +126,7 @@ module testDeployment '../../deploy.bicep' = {
           resourceGroupResources.outputs.managedIdentityPrincipalId
         ]
         roleDefinitionIdOrName: 'Reader'
+        principalType: 'ServicePrincipal'
       }
     ]
     tags: {

From 9dbc47d0ecd22826649089636568b9cb041d98a8 Mon Sep 17 00:00:00 2001
From: Erika Gressi <erikag@microsoft.com>
Date: Thu, 13 Oct 2022 14:43:00 +0200
Subject: [PATCH 2/2] readme

---
 modules/Microsoft.NetApp/netAppAccounts/readme.md | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/modules/Microsoft.NetApp/netAppAccounts/readme.md b/modules/Microsoft.NetApp/netAppAccounts/readme.md
index 46efbb970e..5bb784051e 100644
--- a/modules/Microsoft.NetApp/netAppAccounts/readme.md
+++ b/modules/Microsoft.NetApp/netAppAccounts/readme.md
@@ -437,6 +437,7 @@ module netAppAccounts './Microsoft.NetApp/netAppAccounts/deploy.bicep' = {
             principalIds: [
               '<managedIdentityPrincipalId>'
             ]
+            principalType: 'ServicePrincipal'
             roleDefinitionIdOrName: 'Reader'
           }
         ]
@@ -463,6 +464,7 @@ module netAppAccounts './Microsoft.NetApp/netAppAccounts/deploy.bicep' = {
                 principalIds: [
                   '<managedIdentityPrincipalId>'
                 ]
+                principalType: 'ServicePrincipal'
                 roleDefinitionIdOrName: 'Reader'
               }
             ]
@@ -496,6 +498,7 @@ module netAppAccounts './Microsoft.NetApp/netAppAccounts/deploy.bicep' = {
             principalIds: [
               '<managedIdentityPrincipalId>'
             ]
+            principalType: 'ServicePrincipal'
             roleDefinitionIdOrName: 'Reader'
           }
         ]
@@ -509,6 +512,7 @@ module netAppAccounts './Microsoft.NetApp/netAppAccounts/deploy.bicep' = {
         principalIds: [
           '<managedIdentityPrincipalId>'
         ]
+        principalType: 'ServicePrincipal'
         roleDefinitionIdOrName: 'Reader'
       }
     ]
@@ -550,6 +554,7 @@ module netAppAccounts './Microsoft.NetApp/netAppAccounts/deploy.bicep' = {
               "principalIds": [
                 "<managedIdentityPrincipalId>"
               ],
+              "principalType": "ServicePrincipal",
               "roleDefinitionIdOrName": "Reader"
             }
           ],
@@ -576,6 +581,7 @@ module netAppAccounts './Microsoft.NetApp/netAppAccounts/deploy.bicep' = {
                   "principalIds": [
                     "<managedIdentityPrincipalId>"
                   ],
+                  "principalType": "ServicePrincipal",
                   "roleDefinitionIdOrName": "Reader"
                 }
               ],
@@ -609,6 +615,7 @@ module netAppAccounts './Microsoft.NetApp/netAppAccounts/deploy.bicep' = {
               "principalIds": [
                 "<managedIdentityPrincipalId>"
               ],
+              "principalType": "ServicePrincipal",
               "roleDefinitionIdOrName": "Reader"
             }
           ],
@@ -624,6 +631,7 @@ module netAppAccounts './Microsoft.NetApp/netAppAccounts/deploy.bicep' = {
           "principalIds": [
             "<managedIdentityPrincipalId>"
           ],
+          "principalType": "ServicePrincipal",
           "roleDefinitionIdOrName": "Reader"
         }
       ]