Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Vale integration for markdown formatting and styling #180

Merged
merged 6 commits into from
Jan 17, 2024

Conversation

fcabrera23
Copy link

@fcabrera23 fcabrera23 added the jumpstart enhancement New feature or request related to the Azure Arc Jumpstart scenarios label Dec 12, 2023
@fcabrera23 fcabrera23 self-assigned this Dec 12, 2023
Copy link
Contributor

@likamrat likamrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, couple of minors

@fcabrera23
Copy link
Author

@likamrat added suggested changes - Also, pipeline ran correctly and no markdown errors need to be addressed as part of this PR

@fcabrera23 fcabrera23 requested a review from likamrat December 13, 2023 16:38
Copy link
Contributor

@likamrat likamrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Initial vale configuration

* Update new version of MSFT styling

* Update accept.txt

* Remove extra whitspace

* Fix for only warnings

* Add linting only for modified files

* Apply only to markdown

* Bump to newer verison

* Try again

* Remove filter

* Fail on error

* Dont fail on error

* Add styling guidleines

* Fix support statement
@fcabrera23 fcabrera23 force-pushed the docs-vale-formatting branch from ed37a5c to 86c2cf9 Compare January 10, 2024 18:59
Copy link
Contributor

@likamrat likamrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcabrera23 fcabrera23 merged commit 621dc4d into Azure:canary Jan 17, 2024
2 checks passed
@fcabrera23 fcabrera23 deleted the docs-vale-formatting branch January 17, 2024 18:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
jumpstart enhancement New feature or request related to the Azure Arc Jumpstart scenarios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants