-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Vale integration for markdown formatting and styling #180
Conversation
fcabrera23
commented
Dec 12, 2023
- Initial Vale configuration - For more information, check https://github.com/errata-ai/vale-action
- Microsoft Vale styling - For more information, check https://github.com/errata-ai/Microsoft
- GitHub Actions CI/CD configuration to add PR review
- Added Vale instructions to README.MD
- Updated support statement in SUPPORT.MD
- Starting with warning level for recommendations - Consider moving it to suggestions in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments, couple of minors
@likamrat added suggested changes - Also, pipeline ran correctly and no markdown errors need to be addressed as part of this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Initial vale configuration * Update new version of MSFT styling * Update accept.txt * Remove extra whitspace * Fix for only warnings * Add linting only for modified files * Apply only to markdown * Bump to newer verison * Try again * Remove filter * Fail on error * Dont fail on error * Add styling guidleines * Fix support statement
ed37a5c
to
86c2cf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM