Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

add adobe analytics #299

Closed
wants to merge 7 commits into from
Closed

add adobe analytics #299

wants to merge 7 commits into from

Conversation

hemarina
Copy link
Contributor

@hemarina hemarina commented Feb 2, 2024 •
edited
Loading

fix #278
Local test works well for current PR.
In progress: fixing npm connection to package

@hemarina hemarina self-assigned this Feb 2, 2024
@hemarina hemarina marked this pull request as ready for review February 7, 2024 17:06
weikanglim
weikanglim approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@weikanglim weikanglim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think the build is failing since NPM_TOKEN is unset but I'm guessing that may be just waiting for final setup.

@hemarina
Copy link
Contributor Author

Move to #308

@hemarina hemarina closed this Feb 10, 2024
@hemarina hemarina deleted the adobe branch April 25, 2024 20:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vhvb1989 vhvb1989 vhvb1989 left review comments

@weikanglim weikanglim weikanglim approved these changes

@gkulin gkulin Awaiting requested review from gkulin

@rajeshkamal5050 rajeshkamal5050 Awaiting requested review from rajeshkamal5050 rajeshkamal5050 is a code owner

Assignees

@hemarina hemarina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Adobe support for usage
3 participants
@hemarina @weikanglim @vhvb1989