Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate the CLI packaging system to the latest recommendation #8164

Closed
lmazuel opened this issue Jan 4, 2019 · 4 comments
Closed

Migrate the CLI packaging system to the latest recommendation #8164

lmazuel opened this issue Jan 4, 2019 · 4 comments

Comments

@lmazuel
Copy link
Member

lmazuel commented Jan 4, 2019

I was randomly discussing packaging and CLI impact with @marstr, and I promised I will create an issue about the packaging update to do for CLI. So here it is :)

This means getting rid of azure_bdist_wheel file, using PEP420 for Python 3, etc. A more complete rational can be found here:
https://github.com/Azure/azure-sdk-for-python/wiki/Azure-packaging

I wouldn't say it's urgent, being that it doesn't impact at all the installers (Windows MSI, homebrew, etc.). Main benefits are :

  • For service team development, since it will simplify the dev_setup.py (remove this kind of black magic). pip install --force-reinstall azure-nspkg==1.0.0 should never be needed anymore.
  • Could simplify the "pip install" scenario in some corner case (shouldn't be considered a big concern)

Note that azure_bdist_wheel file logic is broken since an update of setuptools in November 2017, so we could consider as a benefit too removing a file that adds no value and just noise.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 27, 2019

@fengzhou-msft add to S162.

@yonzhan yonzhan modified the milestones: Backlog, S162 Oct 27, 2019
@fengzhou-msft
Copy link
Member

will work on this when support for Python 2 is removed.

@fengzhou-msft fengzhou-msft modified the milestones: S162, S163 Dec 1, 2019
@yonzhan yonzhan modified the milestones: S163, S164 Jan 2, 2020
@yungezz yungezz modified the milestones: S164, S165 Jan 3, 2020
@fengzhou-msft fengzhou-msft modified the milestones: S165, S168 Feb 17, 2020
@jeffb4
Copy link

jeffb4 commented Feb 20, 2020

Just to note, this does impact an internal Python project we wrote because we call out to the azure-cli and thus have this project as a listed dependency (which forces back our setuptools).

So while it surely isn't critical, I'd love to see it.

@fengzhou-msft
Copy link
Member

resolved in version 2.11.0.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

8 participants