Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Application Gateway support for Get Server Variables APIs #8290

Closed
nirkum18 opened this issue Jan 18, 2019 · 8 comments · Fixed by #8870
Closed

Application Gateway support for Get Server Variables APIs #8290

nirkum18 opened this issue Jan 18, 2019 · 8 comments · Fixed by #8870
Assignees
Milestone

Comments

@nirkum18
Copy link

Is your feature request related to a problem? Please describe.
CLI needs to be updated according to the NRP and swagger changes. We have added 3 new APIs to fetch the supported server variables, request and response headers, for Header CRUD feature in Application Gateway. CLI needs to be updated to support these APIs.

Describe the solution you'd like
Need CLI to be written as per the Swagger Changes here.

@tjprescott tjprescott added Network az network vnet/lb/nic/dns/etc... Feature labels Jan 18, 2019
@tjprescott tjprescott added this to the Sprint 55 milestone Jan 18, 2019
@tjprescott tjprescott self-assigned this Jan 18, 2019
@tjprescott
Copy link
Member

API version 2018-11-01.

@tjprescott
Copy link
Member

@nirkum18 I believe there is something wrong with the Swagger specs for these three endpoints. Whenever I try to call them using the Autorest generated SDK, I get the following error:

  File "d:\gitrepos\github\env\lib\site-packages\azure\mgmt\network\v2018_12_01\operations\application_gateways_operations.py", line 955, in list_available_response_headers
    deserialized = models.list(internal_paging, self._deserialize.dependencies)
AttributeError: module 'azure.mgmt.network.v2018_12_01.models' has no attribute 'list'

cc/ @lmazuel

@tjprescott tjprescott added Service Attention This issue is responsible by Azure service team. Network - Application Gateway az network application-gateway and removed Network az network vnet/lb/nic/dns/etc... labels Feb 19, 2019
@tjprescott tjprescott modified the milestones: Sprint 55, Backlog Feb 19, 2019
@tjprescott
Copy link
Member

I will proceed with my PR to bump the Network API version, but I will not add these commands until the specs are fixed.

@nirkum18
Copy link
Author

nirkum18 commented Feb 25, 2019

@nirkum18 I believe there is something wrong with the Swagger specs for these three endpoints. Whenever I try to call them using the Autorest generated SDK, I get the following error:

  File "d:\gitrepos\github\env\lib\site-packages\azure\mgmt\network\v2018_12_01\operations\application_gateways_operations.py", line 955, in list_available_response_headers
    deserialized = models.list(internal_paging, self._deserialize.dependencies)
AttributeError: module 'azure.mgmt.network.v2018_12_01.models' has no attribute 'list'

cc/ @lmazuel

Sorry for the delayed reply. I was OOF in the past week.

@tjprescott Some recent swagger changes related to these changes were pushed to the network-january-release branch. If you the SDK, that you are using, is getting generated from network-december-release branch, it may not contain the recently checkedin changes.

I have generated the SDK with those changes and powershell cmdlets are working fine for me.
Here is the swagger PR link: Azure/azure-rest-api-specs#5113

In this PR we changed the return type of commandlets from a dictionary to a list of strings.

@tjprescott
Copy link
Member

Thanks for the update @nirkum18. When those changes are merged to master, we will be able to proceed.

@tjprescott tjprescott added New Command(s) Network az network vnet/lb/nic/dns/etc... and removed Network - Application Gateway az network application-gateway Service Attention This issue is responsible by Azure service team. labels Feb 25, 2019
@tjprescott tjprescott modified the milestones: Backlog, Sprint 57 Feb 25, 2019
@tjprescott
Copy link
Member

@nirkum18 it seems the network-january-release branch has still not been merged to master? Do you know when this will happen?

@tjprescott tjprescott added Service Attention This issue is responsible by Azure service team. Network - Application Gateway az network application-gateway and removed Network az network vnet/lb/nic/dns/etc... labels Mar 19, 2019
@tjprescott
Copy link
Member

Due to the necessity for Swagger changes, there is no way this will be released this sprint. @nirkum18 please advise when the Swagger fix has been merged and we will reschedule this work accordingly.

@tjprescott tjprescott modified the milestones: Sprint 57, Sprint 59 Mar 19, 2019
@tjprescott
Copy link
Member

Swagger issues have been resolved, so this change will go into Sprint 58.

@tjprescott tjprescott added Network az network vnet/lb/nic/dns/etc... and removed Network - Application Gateway az network application-gateway Service Attention This issue is responsible by Azure service team. labels Mar 21, 2019
@tjprescott tjprescott modified the milestones: Sprint 59, Sprint 58 Mar 21, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants