Skip to content

Do not log language metric in placeholder mode #4227

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
pragnagopa opened this issue Mar 22, 2019 · 9 comments
Closed

Do not log language metric in placeholder mode #4227

pragnagopa opened this issue Mar 22, 2019 · 9 comments
Assignees

Comments

@pragnagopa
Copy link
Member

Do not log language metric in placeholder mode

_metricsLogger.LogEvent(string.Format(MetricEventNames.HostStartupRuntimeLanguage, _workerRuntime));

@pragnagopa pragnagopa added this to the Functions Sprint 45 milestone Mar 22, 2019
@pragnagopa pragnagopa self-assigned this Mar 22, 2019
@pragnagopa
Copy link
Member Author

cc @mhoeger @paulbatum

@pragnagopa pragnagopa modified the milestones: Functions Sprint 46, Triaged Apr 3, 2019
@pragnagopa
Copy link
Member Author

Metric host.startup.runtime.language.dotnet is being emitted for non dotnet apps. This appears to be race condition during specialization. Needs investigation

@paulbatum
Copy link
Member

I confirmed this by looking at a day's worth of telemetry from our cold start runners. This is going to be screwing up our analytics pipeline.

@pragnagopa pragnagopa modified the milestones: Triaged, Functions Sprint 48 Apr 18, 2019
@jeffhollan jeffhollan added the P1 label Apr 19, 2019
@pragnagopa
Copy link
Member Author

pragnagopa commented May 13, 2019

cc - @brettsam
PR # #4356 fixes race condition during specialization. Need to revisit metrics issue where host.startup.runtime.language.dotnet is emitted after an app gets specialized.

@brettsam
Copy link
Member

Do you have an example of the erroneous log? Are we logging this with the customer's app name and dotnet, even though it's not a dotnet app?

@pragnagopa
Copy link
Member Author

An example of error metric: A Java app gets two metrics host.startup.runtime.language.dotnet and host.startup.runtime.language.java. Similarly a node app gets two metrics: host.startup.runtime.language.dotnet and host.startup.runtime.language.node

I will share kusto queries offline.

@pragnagopa
Copy link
Member Author

PR #4210 addresses not logging language metric in placeholder mode. We still need to keep this issue active for investigating duplicate language metric logs

@fabiocav
Copy link
Member

fabiocav commented Jul 9, 2019

@pragnagopa can this be closed now?

@fabiocav fabiocav modified the milestones: Functions Sprint 49, Triaged Jul 9, 2019
@fabiocav fabiocav removed the P1 label Jul 9, 2019
@pragnagopa
Copy link
Member Author

Yes. Thanks to @brettsam for fixing races during specialization!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants