Skip to content

Investigate use of SqlClient ReadAsync #903

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Charles-Gagnon opened this issue Aug 4, 2023 · 0 comments · Fixed by #904
Closed

Investigate use of SqlClient ReadAsync #903

Charles-Gagnon opened this issue Aug 4, 2023 · 0 comments · Fixed by #904
Assignees
@MaddyDev
Labels
enhancement New feature or request Triage: Done
Milestone
Trigger GA

Comments

@Charles-Gagnon
Copy link
Contributor

Turns out there's some known issues with using ReadAsync in SqlClient

dotnet/SqlClient#593
dotnet/SqlClient#44

We currently use ReadAsync in many places, so we should investigate whether we want to switch over to using Read as done here : microsoft/sqltoolsservice#2161
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@MaddyDev MaddyDev

Labels
enhancement New feature or request Triage: Done
Projects
None yet
Milestone
Trigger GA
Development

Successfully merging a pull request may close this issue.

replace read async with read of SqlReader for perf Azure/azure-functions-sql-extension
2 participants
@MaddyDev @Charles-Gagnon