Skip to content
This repository was archived by the owner on May 5, 2023. It is now read-only.

BUG: Azure API management user.createOrUpdate does not pass identities array #3857

Closed
gunzip opened this issue Oct 12, 2018 · 13 comments
Closed

Comments

@gunzip
Copy link
Contributor

gunzip commented Oct 12, 2018

Actually the createOrUpdate op on user object does not pass the "identities" array to post body parameters here:

https://github.com/Azure/azure-sdk-for-node/blob/master/lib/services/apimanagement/lib/operations/user.js#L742

That's because identities is set to 'readonly' here:
https://github.com/Azure/azure-sdk-for-node/blob/master/lib/services/apimanagement/lib/models/userCreateParameters.js#L72

while it's not. Indeed if you manually call the createOrUpdate API passing identities it works correctly.

This prevents to programmatically create users that have a social or Active Directory identity.

see also https://stackoverflow.com/questions/52769817/creating-a-new-user-in-the-api-management-with-adb2c

@ghost ghost added customer-reported This issue was reported by a customer. Unplanned-Sprint-125 labels Oct 12, 2018
@ghost ghost added this to the Sprint-125 milestone Oct 12, 2018
@ghost ghost added to do and removed to do labels Oct 18, 2018
@ghost ghost modified the milestones: Sprint-125, Sprint-126 Oct 18, 2018
@ghost ghost modified the milestones: Sprint-126, Sprint-127 Nov 5, 2018
@ghost ghost added the to do label Nov 5, 2018
@vetrivelmp
Copy link

this will be fixed by 12th November 2018?

@ghost
Copy link

ghost commented Nov 8, 2018

In Sprint-127 our team will be focusing on our customer-reported issues, so we'll try to fix as many as we can. Anything that we can't fix will go into Sprint-128. We should be able to at least look at this issue and determine what next steps we need to take.

@amarzavery
Copy link
Contributor

This looks like a swagger issue. @solankisamir can you please take a look at this issue?

@amarzavery
Copy link
Contributor

Here is the swagger spec that says identities is read-only. Because of which the generated sdk is having identities property as read-only.

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2018-01-01/apimusers.json#L825

@vetrivelmp
Copy link

We have to programatically create B2C user in APIM. so that we will have our user maintenance in one place and it is criticial for us to select APIM as product for managing APIs. we have some strict deadline to complete this feature. So please let us know when this fix will be done.

@gunzip
Copy link
Contributor Author

gunzip commented Nov 12, 2018

@amarzavery
Copy link
Contributor

@amarzavery
Copy link
Contributor

@gunzip - New package 4.3.0-preview has been published to npm. https://www.npmjs.com/package/azure-arm-apimanagement . Let us know if you still see any issues.

@vetrivelmp
Copy link

did the change also implement in Microsoft.Azure.Management.ApiManagement.dll (.net version)?
Url:
https://www.nuget.org/packages/Microsoft.Azure.Management.ApiManagement/

@solankisamir
Copy link
Member

not yet. That might take some time, a week possibly.

@vetrivelmp
Copy link

Please update this issue once it is also implemented in .net version dll.

@solankisamir
Copy link
Member

@ghost
Copy link

ghost commented Nov 26, 2018

Since the NPM and Nuget packages have both been updated with the fix, I'm going to close this issue.

This issue was closed.
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

4 participants