Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add option for distributed traces in test proxy #9984

Open
scbedd opened this issue Mar 5, 2025 · 1 comment
Open

Add option for distributed traces in test proxy #9984

scbedd opened this issue Mar 5, 2025 · 1 comment
Labels
Test-Proxy Anything relating to test-proxy requests or issues.

Comments

@scbedd
Copy link
Member

scbedd commented Mar 5, 2025

After discussion with @heaths , I am adding an item to enable distributed tracing in test-proxy. We should take the opportunity to utilize structured logging for these messages as well.

When flag --distributed-trace is passed, the proxy should generate trace messages in stdout that other applications can consume.

This will probably require a refactor of logging in general in the proxy to get all these outputs figured out

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 5, 2025
@scbedd scbedd added Test-Proxy Anything relating to test-proxy requests or issues. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Mar 5, 2025
@heaths
Copy link
Member

heaths commented Mar 5, 2025

This will probably require a refactor of logging in general in the proxy to get all these outputs figured out

Not necessarily. We could optionally trace from the existing ILogger messages and if you wanted to keep tracing compatible, perhaps those would log a specific trace field that could be used for identification e.g., log = "existing messages, new lines and all". I could start with that and it wouldn't prevent future growth possibilities.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Test-Proxy Anything relating to test-proxy requests or issues.
Projects
Status: 🤔 Triage
Development

No branches or pull requests

2 participants