Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Detect breaking changes in api layer of modular client #9988

Open
wanlwanl opened this issue Mar 6, 2025 · 1 comment
Open

Detect breaking changes in api layer of modular client #9988

wanlwanl opened this issue Mar 6, 2025 · 1 comment
Assignees

Comments

@wanlwanl
Copy link
Member

wanlwanl commented Mar 6, 2025

Due to

  1. root layer may keep backward compability when api layer has breaking changes
  2. decide to set hierarchyClient to true by deault according to subpath exports for hierarchyClient true export internal send and deserialize function autorest.typescript#2699 (comment)
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 6, 2025
@wanlwanl
Copy link
Member Author

wanlwanl commented Mar 6, 2025

Hi @qiaozha , @MaryGao @joheredi I created this issue for supporting hierarchyClient better, and set an appropreate priority, could you comment in the issue about:

  1. in what cases we have breaking changes in api layer while no in root layer?
  2. what's the number of RP get impact?
  3. case 1: only detect breaking changes in api layer vs case 2: detect breaking changes in both root layer and api layer: what the spec review flow will be? These two cases block PR merges? When to allow case 1 in spec review flow?

@wanlwanl wanlwanl self-assigned this Mar 6, 2025
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 6, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant