Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Task: /Bug: Gracefully handle Azure Delete on MySqlServer #1032

Closed
1 task
melonrush13 opened this issue May 8, 2020 · 0 comments · Fixed by #1044
Closed
1 task

Task: /Bug: Gracefully handle Azure Delete on MySqlServer #1032

melonrush13 opened this issue May 8, 2020 · 0 comments · Fixed by #1044
Assignees

Comments

@melonrush13
Copy link
Contributor

melonrush13 commented May 8, 2020

When I delete a MySqlServer instance on the Azure portal, the operator doesn't register that delete and throws an error with code OperationIdNotFound

2020-05-08T09:14:30.533-0600    ERROR    controller-runtime.controller    Reconciler error    {"controller": "mysqlserver", "request": "default/aso-wpdemo-mysqlserver", "error": "1 error occurred:\n\t* sql.PollClient#Get: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code=\"OperationIdNotFound\" Message=\"The operation with Id: '1dfe0027-356f-461a-af64-d4a81df4fcd5' does not exist.\"\n\n"}
github.com/go-logr/zapr.(*zapLogger).Error
    /Users/melanierush/go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
    /Users/melanierush/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.5.0/pkg/internal/controller/controller.go:258
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
    /Users/melanierush/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.5.0/pkg/internal/controller/controller.go:232
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker
    /Users/melanierush/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.5.0/pkg/internal/controller/controller.go:211
k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1
    /Users/melanierush/go/pkg/mod/k8s.io/apimachinery@v0.17.2/pkg/util/wait/wait.go:152
k8s.io/apimachinery/pkg/util/wait.JitterUntil
    /Users/melanierush/go/pkg/mod/k8s.io/apimachinery@v0.17.2/pkg/util/wait/wait.go:153
k8s.io/apimachinery/pkg/util/wait.Until
    /Users/melanierush/go/pkg/mod/k8s.io/apimachinery@v0.17.2/pkg/util/wait/wait.go:88
2020-05-08T09:14:40.776-0600    INFO    controllers.MySQLServer    setting parent reference    {"Info Ty

To Re Create

  • Create a MySqlServer using the operator
  • Verify existence on operator and Azure
  • Delete the server using the Azure portal
  • Observe the output from the reconciler - should see zapper err from above with continuous reconciliation

Done criteria
Gracefully handle a delete from Azure side and reflect it on the operator side.

  • For eg. After this task is done, the user should be able to use either webhooks or the declarative model for K8s

User story reference

#

@melonrush13 melonrush13 changed the title Task: Gracefully handle Azure Delete on MySqlServer Task: /Bug: Gracefully handle Azure Delete on MySqlServer May 8, 2020
@WilliamMortlMicrosoft WilliamMortlMicrosoft self-assigned this May 11, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants