Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Question ManagedCluster - Can credential for Windows & Linux node be passed as secret instead of plain text #4088

Closed
RSE132 opened this issue Jun 14, 2024 · 1 comment · Fixed by #4091
Labels
bug 🪲 Something isn't working question Further information is requested
Milestone

Comments

@RSE132
Copy link

RSE132 commented Jun 14, 2024

Can credential for Windows & Linux node be passed as secret instead of plain text ?

Current supported

# Linux node public key profile
      linuxProfile:
        adminUsername: "azureuser"
        ssh:
          publicKeys:                                        # SSH Key for node
          - keyData: |
              ssh-rsa xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
# Windows node credential profile
      windowsProfile:
        adminUsername: "azureuser"
        adminPassword: "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"

Expectation

# Linux node public key profile
      linuxProfile:
        adminUsername: "azureuser"
        ssh:
          publicKeys:                                        # SSH Key for node
          - keyData:
               secret:
                  key:
                  value:
# Windows node credential profile
      windowsProfile:
        adminUsername: "azureuser"
        adminPassword:
           secret:
              key:
              value:

@matthchr
Copy link
Member

For Linux, the key you're passing there is the publicKey and so isn't secret and thus can't be passed from a secret on purpose.

The WindowsProfile adminpassword should support secret and the fact it doesn't is an oversight which we will fix. I've tagged this as a bug.

@matthchr matthchr added this to the v2.8.0 milestone Jun 14, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Recently Completed in Azure Service Operator Roadmap Jun 19, 2024
@theunrepentantgeek theunrepentantgeek moved this from Recently Completed to Ready for Release in Azure Service Operator Roadmap Jun 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug 🪲 Something isn't working question Further information is requested
Projects
Development

Successfully merging a pull request may close this issue.

2 participants