Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Task: Remove functions used in errhelp.go across controllers #628

Closed
melonrush13 opened this issue Feb 12, 2020 · 0 comments · Fixed by #1044
Closed

Task: Remove functions used in errhelp.go across controllers #628

melonrush13 opened this issue Feb 12, 2020 · 0 comments · Fixed by #1044
Assignees

Comments

@melonrush13
Copy link
Contributor

melonrush13 commented Feb 12, 2020

We are using functions from errhelp.go such as IsStatusCode204, and IsStatusCode404. We want to remove these function calls used throughout the controllers and have them use errors.go string checks instead (such as ParentNotFoundErrorCode) to be consistent across controllers.

In Addition, we would also like to ideally error check from HTTP status codes instead of strings.

Done criteria
Remove string functions and instead error check them from errors.go

Fix in the following controllers..

  • Azure SQL Firewall Rule
  • Azure DataLake
  • Cosmos DB
  • Storage Controller
  • Azure SQL DB
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants