Storage Credentials

[WilliamMortlMicrosoft]

closes #913

Describe the bug
We currently do not store credentials for the storage account. We should store those in a secret, and remove the StorageOutput struct, which is not being used either.

type StorageOutput struct {
	StorageAccountName string `json:"storageAccountName,omitempty"`
	Key1               string `json:"key1,omitempty"`
	Key2               string `json:"key2,omitempty"`
	ConnectionString1  string `json:"connectionString1,omitempty"`
	ConnectionString2  string `json:"connectionString2,omitempty"`
}

To Reproduce
Steps to reproduce the behavior:
Create SA, no secret is created

Expected behavior
When creating a storage account, a secret should be created with credentials for connecting to the storage account, with the following fields:

	StorageAccountName string `json:"storageAccountName,omitempty"`
	Key1               string `json:"key1,omitempty"`
	Key2               string `json:"key2,omitempty"`
	ConnectionString1  string `json:"connectionString1,omitempty"`
	ConnectionString2  string `json:"connectionString2,omitempty"`

Completion Criteria

• Secret is created with credentials
• StorageOutput struct is removed from types.go
• Docs are updated with secret information

[WilliamMortlMicrosoft]

secret:

Williams-MacBook-Pro:samples wmortl$ kubectl get secret storageaccount-resourcegroup-azure-operators-wmm-storageaccountsamplewmm1 -o yaml
apiVersion: v1
data:
  StorageAccountName: c3RvcmFnZWFjY291bnRzYW1wbGV3bW0x
  connectionString0: RGVmYXVsdEVuZHBvaW50c1Byb3RvY29sPWh0dHBzO0FjY291bnROYW1lPXN0b3JhZ2VhY2NvdW50c2FtcGxld21tMTtBY2NvdW50S2V5PTlUWnZOZHdUNEhMSlY5NlZrVm1hbW5iUnhRVUJGNW1iVmlHdVRMTENKd3hhUVFpS1FjN1VxaHpFWVRwUUZRQk94OWVIemNpZDE2Qk9sbkp6a3FlajJRPT07RW5kcG9pbnRTdWZmaXg9Y29yZS53aW5kb3dzLm5ldA==
  connectionString1: RGVmYXVsdEVuZHBvaW50c1Byb3RvY29sPWh0dHBzO0FjY291bnROYW1lPXN0b3JhZ2VhY2NvdW50c2FtcGxld21tMTtBY2NvdW50S2V5PXZ5dXVRRm85UXhmdWYxYTBVSWRaUzBqVzBlRVo1NWhrcHFpTm4xRkh5c09WQ1p4NkxPT1JLcFh4RzRoUmRDQUljVnBiR1lkK1NYOW1OOVdRb25zWlhnPT07RW5kcG9pbnRTdWZmaXg9Y29yZS53aW5kb3dzLm5ldA==
  key0: OVRadk5kd1Q0SExKVjk2VmtWbWFtbmJSeFFVQkY1bWJWaUd1VExMQ0p3eGFRUWlLUWM3VXFoekVZVHBRRlFCT3g5ZUh6Y2lkMTZCT2xuSnprcWVqMlE9PQ==
  key1: dnl1dVFGbzlReGZ1ZjFhMFVJZFpTMGpXMGVFWjU1aGtwcWlObjFGSHlzT1ZDWng2TE9PUktwWHhHNGhSZENBSWNWcGJHWWQrU1g5bU45V1FvbnNaWGc9PQ==
kind: Secret
metadata:
  creationTimestamp: "2020-04-27T21:05:42Z"
  name: storageaccount-resourcegroup-azure-operators-wmm-storageaccountsamplewmm1
  namespace: default
  ownerReferences:
  - apiVersion: azure.microsoft.com/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: StorageAccount
    name: storageaccountsamplewmm1
    uid: 1077cc0e-4fe3-4ff7-8b40-3028aab78181
  resourceVersion: "4654"
  selfLink: /api/v1/namespaces/default/secrets/storageaccount-resourcegroup-azure-operators-wmm-storageaccountsamplewmm1
  uid: 09a9fefd-35c9-4ee7-83b5-8aa1575a2c02
type: Opaque

[jananivMS]

Functionality looks good but it looks like the PR might need to be updated with master. I can re-review and approve then

[WilliamMortlMicrosoft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jananivMS]

Tested and functionality looks good. A couple of comments that needs addressing and this should be good to go.

[jananivMS]

Tested and looks good