Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handle VirtualNetworkRuleBadRequest error for VNetRule #1010

Merged
merged 4 commits into from
Apr 30, 2020
Merged

Handle VirtualNetworkRuleBadRequest error for VNetRule #1010

merged 4 commits into from
Apr 30, 2020

Conversation

melonrush13
Copy link
Contributor

@melonrush13 melonrush13 commented Apr 28, 2020

Closes #1006

What this PR does / why we need it:
If a user creates a VNetRule on MySqlServer or PostgreSqlServer with a server on EastUS instead of WestUS, the reconciler continues to error "VirtualNetworkRuleBadRequest".'

This PR catches that error, and throws a failed provision state because it will never be provision correctly.

Special notes for your reviewer:

  • Create a Postgresqlserver in EastUS
  • Create a VirtualNetwork
  • Create a PostgreSqlVNetRule with the above

(same with MySql)

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

Copy link
Contributor

@WilliamMortlMicrosoft WilliamMortlMicrosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :-)

@melonrush13 melonrush13 merged commit 09896b1 into Azure:master Apr 30, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Address VirtualNetworkRuleBadRequest in PostgreSql and MySql
2 participants